lkml.org 
[lkml]   [2020]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/6] PCI: brcmstb: Add control of EP voltage regulator(s)
On Wed, Nov 25, 2020 at 02:24:19PM -0500, Jim Quinlan wrote:

> + for (i = 0; i < PCIE_REGULATORS_MAX; i++) {
> + ep_reg = devm_regulator_get_optional(dev, ep_regulator_names[i]);
> + if (IS_ERR(ep_reg)) {

Does PCI allow supplies to be physically absent? If not then the driver
shouldn't be using regulator_get_optional() and much of the code here
can be deleted.

> +static void brcm_set_regulators(struct brcm_pcie *pcie, bool on)
> +{

This is open coding the regulator bulk APIs.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-11-26 12:53    [W:0.234 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site