lkml.org 
[lkml]   [2020]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data
On Wed, Nov 25, 2020 at 10:29:11PM +0900, Namhyung Kim wrote:

SNIP

> > +#ifdef HAVE_DEBUGINFOD_SUPPORT
> > +static int call_debuginfod(const char *sbuild_id, char **path, bool debuginfo)
> > +{
> > + debuginfod_client *c;
> > + int fd;
> > +
> > + c = debuginfod_begin();
> > + if (c == NULL)
> > + return -1;
> > +
> > + pr_debug("trying debuginfod for executable <%s> ... ", sbuild_id);
> > +
> > + if (debuginfo) {
> > + fd = debuginfod_find_debuginfo(c, (const unsigned char *) sbuild_id,
> > + 0, path);
> > + } else {
> > + fd = debuginfod_find_executable(c, (const unsigned char *) sbuild_id,
> > + 0, path);
> > + }
> > + if (fd >= 0)
> > + close(fd); /* retaining reference by realname */
> > +
> > + debuginfod_end(c);
> > + pr_debug("%s%s\n", *path ? "OK " : "FAILED", *path ? *path : "");
> > + return *path ? 0 : -1;
> > +}
> > +#else
> > +static int call_debuginfod(const char *sbuild_id __maybe_unused,
> > + char **path __maybe_unused,
> > + bool debuginfo __maybe_unused)
> > +{
> > + return -1;
> > +}
> > +#endif
> > +
> > +struct dso_store_data {
> > + bool hits;
> > + bool force_download;
>
> Where is it set?

it's not, I wanted to add it, but then never needed it,
so it stayed without an option.. I'll remove it

thanks,
jirka

\
 
 \ /
  Last update: 2020-11-25 15:21    [W:0.097 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site