lkml.org 
[lkml]   [2020]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v3 00/10] Introduced new Cadence USBSSP DRD Driver.
    Date

    > >>>
    > >>> The device side of USBSS DRD controller is compliant with XHCI.
    > >>> The architecture for device side is almost the same as for host
    > >>> side, and most of the XHCI specification can be used to understand
    > >>> how this controller operates.
    > >>>
    > >>> This controller and driver support Full Speed, Hight Speed, Supper
    > >>> Speed and Supper Speed Plus USB protocol.
    > >>>
    > >>> The prefix cdnsp used in driver has chosen by analogy to cdn3 driver.
    > >>> The last letter of this acronym means PLUS. The formal name of
    > >>> controller is USBSSP but it's to generic so I've decided to use CDNSP.
    > >>>
    > >>> The patch 1: adds support for DRD CDNSP.
    > >>> The patch 2: separates common code that can be reusable by cdnsp driver.
    > >>> The patch 3: moves reusable code to separate module.
    > >>> The patch 4: changes prefixes in reusable code from cdns3 to common
    > cdns.
    > >>> The patch 5: adopts gadget_dev pointer in cdns structure to make possible
    > >>> use it in both drivers.
    > >>> The patches 6-8: add the main part of driver and has been intentionally
    > >>> split into 3 part. In my opinion such division should not
    > >>> affect understanding and reviewing the driver, and cause
    > that
    > >>> main patch (7/8) is little smaller. Patch 6 introduces main
    > >>> header file for driver, 7 is the main part that implements
    > all
    > >>> functionality of driver and 8 introduces tracepoints.
    > >>> The patch 9: Adds cdns3 prefixes to files related with USBSS driver.
    > >>> the patch 10: Adds USBSSP DRD IP driver entry to MAINTAINERS file.
    > >>>
    > >>> Changlog from v2:
    > >>> - removed not used pdev parameter from cdnsp_read/wite_64 functions
    > >>> - fixed incorrect value assigned to CDNSP_ENDPOINTS_NUM (32 -> 31)
    > >>> - replaced some constant value with CDNSP_ENDPOINTS_NUM macro
    > >>> - replaced 'true' with '1' in bits description in cdnsp-gadget.h
    > >>> file
    > >>> - fixed some typos
    > >>> - some other less important changes suggested by Peter Chen
    > >>
    > >>Hi Pawel,
    > >>
    > >>I have updated my -next tree as the latest usb-next tree which
    > >>v5.10-rc4 is included, would you please rebase my tree and send again,
    > >>I could apply your patches and test, if test could pass, I will apply it to my
    > -next tree.
    > >>You don't need to rebase again since it is a huge patch set, will take
    > >>some efforts for rebase.
    > >>
    > >
    > >I'll try to post it tomorrow.
    >
    > Can I send the new version CDNSP or I should wait for completion
    > 'Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"' and
    > applying the appropriate fix to your repo ?
    >

    Please wait that fix, thanks.

    Peter

    \
     
     \ /
      Last update: 2020-11-25 07:55    [W:5.138 / U:0.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site