lkml.org 
[lkml]   [2020]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] leds: lp50xx: Fix an error handling path in 'lp50xx_probe_dt()'
Hi!

> > > > I have been trying to teach Smatch to understand reference counting so
> > > > it can discover these kinds of bugs automatically.
> > > >
> > > > I don't know how software_node_get_next_child() can work when it doesn't
> > > > call kobject_get(). This sort of bug would have been caught in testing
> > > > because it affects the success path so I must be reading the code wrong.
> > > >
> > >
> > > I had the same reading of the code and thought that I was missing something
> > > somewhere.
> > >
> > > There is the same question about 'acpi_get_next_subnode' which is also a
> > > '.get_next_child_node' function, without any ref counting, if I'm correct.
> > >
> >
> > Yeah, but there aren't any ->get/put() ops for the acpi_get_next_subnode()
> > stuff so it's not a problem. (Presumably there is some other sort of
> > refcounting policy there).
>
> OK, so I guess we need to make software_node_get_next_child()
> mimic the behaviour of of_get_next_available_child(), and not
> acpi_get_next_subnode(). Does the attached patch work?

Does not sound unreasonable. Did it get solved, somehow?

Best regards,
Pavel

--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-11-25 11:51    [W:0.063 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site