Messages in this thread | | | Date | Thu, 26 Nov 2020 09:45:40 +0800 | From | Can Guo <> | Subject | Re: [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to remove skip_ref_clk |
| |
On 2020-11-26 03:02, Bean Huo wrote: > On Wed, 2020-11-25 at 20:28 +0800, Can Guo wrote: >> > On Wed, 2020-11-25 at 08:53 +0800, Can Guo wrote: >> > > > > + bool always_on_while_link_active; >> > > > >> > > > Can, >> > > > using a sentence as a parameter name looks a little bit clumsy >> > > > to >> > > > me. >> > > > The meaning has been explained in the comments section. How >> > > > about >> > > > simplify it and in line with other parameters in the structure? >> > > > >> > > >> > > Do you have a better name in mind? >> > > >> > >> > no specail input in mind, maybe just "bool eternal_on" >> >> It is like plain "always_on", but it cannot tell the whole story. >> If it is not something crutial, let's just let it go first so long >> as it does not break the original functionality. What do you say? >> >> Thanks, >> >> Can Guo. > > Can, > > yes, it is not functional change, but always_on_while_link_active is > too fat, and not non-productive way. > anyway,
I will change it to keep_link_active in next version. Thank you sir.
Regards,
Can Guo.
> > Reviewed-by: Bean Huo <beanhuo@micron.com>
| |