lkml.org 
[lkml]   [2020]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang
    Hi Sam,

    On Sun, Nov 22, 2020 at 11:05:40PM +0100, Sam Ravnborg wrote:
    > Hi Gustavo,
    > On Fri, Nov 20, 2020 at 12:40:32PM -0600, Gustavo A. R. Silva wrote:
    > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > > by explicitly adding a break statement instead of letting the code fall
    > > through to the next case.
    > >
    > > Link: https://github.com/KSPP/linux/issues/115
    > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    >
    > Thanks, applied this and the following patch to drm-misc-next.
    > Looks forward to have this warning enabled.
    >
    > One can only wonder how many hours will be saved by lettting the
    > compiler tell you a break is missing. This is the kind of bugs you can
    > stare you blind at.

    Absolutely. We'll never know how many bugs this will catch in the
    future decades of kernel development, before the code is even
    committed/submitted. :)

    Thanks!
    --
    Gustavo

    \
     
     \ /
      Last update: 2020-11-24 15:44    [W:2.740 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site