Messages in this thread | | | From | "Ardelean, Alexandru" <> | Subject | RE: [PATCH v2 1/3] spi: convert to BIT() all spi_device flags | Date | Tue, 24 Nov 2020 12:03:15 +0000 |
| |
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Tuesday, November 24, 2020 1:50 PM > To: kernel test robot <lkp@intel.com> > Cc: Ardelean, Alexandru <alexandru.Ardelean@analog.com>; linux-spi <linux- > spi@vger.kernel.org>; devicetree <devicetree@vger.kernel.org>; Linux Kernel > Mailing List <linux-kernel@vger.kernel.org>; kbuild-all@lists.01.org; Mark > Brown <broonie@kernel.org>; Rob Herring <robh+dt@kernel.org>; Bogdan, > Dragos <Dragos.Bogdan@analog.com> > Subject: Re: [PATCH v2 1/3] spi: convert to BIT() all spi_device flags > > On Tue, Nov 24, 2020 at 1:42 PM kernel test robot <lkp@intel.com> wrote: > > > All warnings (new ones prefixed by >>): > > > > In file included from drivers/spi/spidev.c:26: > > >> include/uapi/linux/spi/spidev.h:33: warning: "SPI_CPHA" redefined > > 33 | #define SPI_CPHA 0x01 > > Argh! Can we have only one set of flags? >
My bad here for not catching this earlier.
It might be an idea to create a "include/uapi/linux/spi/spi.h" and include this in " include/uapi/linux/spi/spidev.h " Then the " include/uapi/linux/spi/spi.h " would also be included in " include/linux/spi/spi.h " We would naturally drop the BIT() macros for the uapi header.
> -- > With Best Regards, > Andy Shevchenko
| |