lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 014/158] net: ethernet: ti: cpsw: fix error return code in cpsw_probe()
    Date
    From: Zhang Changzhong <zhangchangzhong@huawei.com>

    [ Upstream commit 35f735c665114840dcd3142f41148d07870f51f7 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    Link: https://lore.kernel.org/r/1605250173-18438-1-git-send-email-zhangchangzhong@huawei.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/ti/cpsw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/ti/cpsw.c
    +++ b/drivers/net/ethernet/ti/cpsw.c
    @@ -2876,6 +2876,7 @@ static int cpsw_probe(struct platform_de
    CPSW_MAX_QUEUES, CPSW_MAX_QUEUES);
    if (!ndev) {
    dev_err(dev, "error allocating net_device\n");
    + ret = -ENOMEM;
    goto clean_cpts;
    }


    \
     
     \ /
      Last update: 2020-11-23 14:09    [W:4.408 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site