lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 125/158] HID: logitech-dj: Fix an error in mse_bluetooth_descriptor
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    commit eec231e060fb79923c349f6e89f022b286f32c1e upstream.

    Fix an error in the mouse / INPUT(2) descriptor used for quad/bt2.0 combo
    receivers. Replace INPUT with INPUT (Data,Var,Abs) for the field for the
    4 extra buttons which share their report-byte with the low-res hwheel.

    This is likely a copy and paste error. I've verified that the new
    0x81, 0x02 value matches both the mouse descriptor for the currently
    supported MX5000 / MX5500 receivers, as well as the INPUT(2) mouse
    descriptors for the Dinovo receivers for which support is being
    worked on.

    Cc: stable@vger.kernel.org
    Fixes: f2113c3020ef ("HID: logitech-dj: add support for Logitech Bluetooth Mini-Receiver")
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/hid-logitech-dj.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hid/hid-logitech-dj.c
    +++ b/drivers/hid/hid-logitech-dj.c
    @@ -328,7 +328,7 @@ static const char mse_bluetooth_descript
    0x25, 0x01, /* LOGICAL_MAX (1) */
    0x75, 0x01, /* REPORT_SIZE (1) */
    0x95, 0x04, /* REPORT_COUNT (4) */
    - 0x81, 0x06, /* INPUT */
    + 0x81, 0x02, /* INPUT (Data,Var,Abs) */
    0xC0, /* END_COLLECTION */
    0xC0, /* END_COLLECTION */
    };

    \
     
     \ /
      Last update: 2020-11-23 13:45    [W:4.256 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site