lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages
    From
    Date
    On 21.11.20 20:53, Andrea Arcangeli wrote:
    > On Sat, Nov 21, 2020 at 02:45:06PM -0500, Andrea Arcangeli wrote:
    >> + if (likely(!PageReserved(page)))
    >
    > NOTE: this line will have to become "likely(page &&
    > !PageReserved(page))" to handle the case of non contiguous zones,
    > since pageblock_pfn_to_page might return NULL in that case.. I noticed
    > right after sending, but I'll wait some feedback before resending the
    > correction in case it gets fixed in another way.

    With that fixed, this looks sane to me.


    --
    Thanks,

    David / dhildenb

    \
     
     \ /
      Last update: 2020-11-23 12:28    [W:3.269 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site