lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] PM / EM: Micro optimization in em_pd_energy
On Mon, Nov 23, 2020 at 10:28:39AM +0000, Quentin Perret wrote:
> Hi Pavan,
>
> On Monday 23 Nov 2020 at 15:47:57 (+0530), Pavankumar Kondeti wrote:
> > When the sum of the utilization of CPUs in a power domain is zero,
>
> s/power/performance
>
> > return the energy as 0 without doing any computations.
> >
> > Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> > ---
> > include/linux/energy_model.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> > index b67a51c..8810f1f 100644
> > --- a/include/linux/energy_model.h
> > +++ b/include/linux/energy_model.h
> > @@ -103,6 +103,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
> > struct em_perf_state *ps;
> > int i, cpu;
> >
> > + if (!sum_util)
> > + return 0;
> > +
> > /*
> > * In order to predict the performance state, map the utilization of
> > * the most utilized CPU of the performance domain to a requested
>
> Makes sense to me, so with nit above:
>
> Acked-by: Quentin Perret <qperret@google.com>
>
Thanks Quentin. I have updated the patch as per your correction.

Thanks,
Pavan

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2020-11-23 11:46    [W:0.077 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site