lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error
On Mon, Nov 23, 2020 at 8:55 AM Maulik Shah <mkshah@codeaurora.org> wrote:
> On 11/21/2020 12:03 PM, John Stultz wrote:
> > The kernel test robot reported the following build error:
> >
> > All errors (new ones prefixed by >>):
> >
> > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel':
> > qcom-rpmh-regulator.c:(.text+0x270): undefined reference to `rpmh_write'
> > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request':
> > qcom-rpmh-regulator.c:(.text+0x2f2): undefined reference to `rpmh_write'
> > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel':
> >>> qcom-rpmh-regulator.c:(.text+0x274): undefined reference to `rpmh_write_async'
> > xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request':
> > qcom-rpmh-regulator.c:(.text+0x2fc): undefined reference to `rpmh_write_async'
> >
> > Which is due to REGULATOR_QCOM_RPMH depending on
> > QCOM_RPMH || COMPILE_TEST. The problem is that QOM_RPMH can now
> > be a module, which in that case requires REGULATOR_QCOM_RPMH=m
> > to build.
> >
> > However, if COMPILE_TEST is enabled, REGULATOR_QCOM_RPMH can be
> > set to =y while REGULATOR_QCOM_RPMH=m which will cause build
> > failures.
> Seems typo here, you mean to say, REGULATOR_QCOM_RPMH can be set to =y
> while QCOM_RPMH=m....

Ah, yes, thanks for catching that. I'll fix it up.

> > The easy fix here is to remove COMPILE_TEST.
>
> As config QCOM_RPMH also has COMPILE_TEST, i don't see why it should be
> removed from REGULATOR_QCOM_RPMH.
>
> Can REGULATOR_QCOM_RPMH have depends on ARCH_QCOM set similar to
> QCOM_RPMH? As test bot reported build errors on other ARCH with
> regulatore driver of QCOM arch.

I think Mark's suggestion of "|| (QCOM_RPMH=n && COMPILE_TEST)" is
probably better, as you could still trigger the build issue with a
ARCH_QCOM and compile test. But I appreciate the suggestion!

Thanks so much for the review!
-john

\
 
 \ /
  Last update: 2020-11-23 22:35    [W:0.592 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site