lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/6] relay: allow the use of const callback structs
Date
On Thu, 19 Nov 2020, Christoph Hellwig <hch@infradead.org> wrote:
> But taking one step back: All instances implement create_buf_file
> and remove_buf_file, which makes sense as that is the prime aim
> of these methods. So there is no point in making those optional.
> subbuf_start_callback is overriden by two instances, so making that
> optional totally makes sense. buf_mapped and buf_unmapped are
> never overriden, so they should be removed entirely.
>
> More importantly there is no case that passes a NULL rchan_callbacks,
> which makes complete sense as it wouldn't even create a file. So
> remove that case as well and just replace it with a sanity check in
> relay_open().

Many thanks for the feedback; sent v2 [1].

BR,
Jani.


[1] http://lore.kernel.org/r/cover.1606153547.git.jani.nikula@intel.com


--
Jani Nikula, Intel Open Source Graphics Center

\
 
 \ /
  Last update: 2020-11-23 19:10    [W:0.338 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site