lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv8 3/8] iommu/arm-smmu: Move non-strict mode to use domain_attr_io_pgtbl_cfg
On 2020-11-23 20:49, Will Deacon wrote:
> On Tue, Nov 17, 2020 at 08:00:42PM +0530, Sai Prakash Ranjan wrote:
>> Now that we have a struct domain_attr_io_pgtbl_cfg with quirks,
>> use that for non_strict mode as well thereby removing the need
>> for more members of arm_smmu_domain in the future.
>>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> drivers/iommu/arm/arm-smmu/arm-smmu.c | 7 ++-----
>> drivers/iommu/arm/arm-smmu/arm-smmu.h | 1 -
>> 2 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> b/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> index 7b05782738e2..5f066a1b7221 100644
>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> @@ -786,9 +786,6 @@ static int arm_smmu_init_domain_context(struct
>> iommu_domain *domain,
>> goto out_clear_smmu;
>> }
>>
>> - if (smmu_domain->non_strict)
>> - pgtbl_cfg.quirks |= IO_PGTABLE_QUIRK_NON_STRICT;
>> -
>> if (smmu_domain->pgtbl_cfg.quirks)
>> pgtbl_cfg.quirks |= smmu_domain->pgtbl_cfg.quirks;
>>
>> @@ -1527,7 +1524,7 @@ static int arm_smmu_domain_get_attr(struct
>> iommu_domain *domain,
>> case IOMMU_DOMAIN_DMA:
>> switch (attr) {
>> case DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE:
>> - *(int *)data = smmu_domain->non_strict;
>> + *(int *)data = smmu_domain->pgtbl_cfg.quirks;
>
> Probably better to compare with IO_PGTABLE_QUIRK_NON_STRICT here even
> though
> we only support this one quirk for DMA domains atm.
>

Ok will do, thanks.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2020-11-23 17:51    [W:0.264 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site