lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[RFC PATCH] regmap: remove duplicate `type` field from `regcache_sync` trace event
Date
I had an error saying that `regcache_sync` had 2 fields named `type` while using
libtraceevent. This was the format of this event:

$ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format
name: regcache_sync
ID: 1216
format:
field:unsigned short common_type; offset:0; size:2; signed:0;
field:unsigned char common_flags; offset:2; size:1; signed:0;
field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;

field:__data_loc char[] name; offset:8; size:4; signed:1;
field:__data_loc char[] status; offset:12; size:4; signed:1;
field:__data_loc char[] type; offset:16; size:4; signed:1;
field:int type; offset:20; size:4; signed:1;

print fmt: "%s type=%s status=%s", __get_str(name), __get_str(type), __get_str(status)

Erase the `int field` type, who was not assigned. This field was introduce by mistake and this commit removes it.

This is the format of this event after the fix:

$ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format
name: regcache_sync
ID: 1266
format:
field:unsigned short common_type; offset:0; size:2; signed:0;
field:unsigned char common_flags; offset:2; size:1; signed:0;
field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;

field:__data_loc char[] name; offset:8; size:4; signed:1;
field:__data_loc char[] status; offset:12; size:4; signed:1;
field:__data_loc char[] type; offset:16; size:4; signed:1;

print fmt: "%s type=%s status=%s", __get_str(name), __get_str(type), __get_str(status)

Signed-off-by: Philippe Duplessis-Guindon <pduplessis@efficios.com>
---
drivers/base/regmap/trace.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h
index d4066fa079ab..9abee14df9ee 100644
--- a/drivers/base/regmap/trace.h
+++ b/drivers/base/regmap/trace.h
@@ -126,7 +126,6 @@ TRACE_EVENT(regcache_sync,
__string( name, regmap_name(map) )
__string( status, status )
__string( type, type )
- __field( int, type )
),

TP_fast_assign(
--
2.25.1
\
 
 \ /
  Last update: 2020-11-23 17:23    [W:0.046 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site