lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 032/252] net/smc: fix direct access to ib_gid_addr->ndev in smc_ib_determine_gid()
    Date
    From: Karsten Graul <kgraul@linux.ibm.com>

    [ Upstream commit 41a0be3f8f6be893860b991eb10c47fc3ee09d7f ]

    Sparse complaints 3 times about:
    net/smc/smc_ib.c:203:52: warning: incorrect type in argument 1 (different address spaces)
    net/smc/smc_ib.c:203:52: expected struct net_device const *dev
    net/smc/smc_ib.c:203:52: got struct net_device [noderef] __rcu *const ndev

    Fix that by using the existing and validated ndev variable instead of
    accessing attr->ndev directly.

    Fixes: 5102eca9039b ("net/smc: Use rdma_read_gid_l2_fields to L2 fields")
    Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/smc/smc_ib.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/net/smc/smc_ib.c
    +++ b/net/smc/smc_ib.c
    @@ -198,9 +198,9 @@ int smc_ib_determine_gid(struct smc_ib_d
    rcu_read_lock();
    ndev = rdma_read_gid_attr_ndev_rcu(attr);
    if (!IS_ERR(ndev) &&
    - ((!vlan_id && !is_vlan_dev(attr->ndev)) ||
    - (vlan_id && is_vlan_dev(attr->ndev) &&
    - vlan_dev_vlan_id(attr->ndev) == vlan_id)) &&
    + ((!vlan_id && !is_vlan_dev(ndev)) ||
    + (vlan_id && is_vlan_dev(ndev) &&
    + vlan_dev_vlan_id(ndev) == vlan_id)) &&
    attr->gid_type == IB_GID_TYPE_ROCE) {
    rcu_read_unlock();
    if (gid)

    \
     
     \ /
      Last update: 2020-11-23 14:41    [W:2.967 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site