lkml.org 
[lkml]   [2020]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH net-next 0/3] net: ptp: use common defines for PTP message types in further drivers
    Date
    This series replaces further driver internal enumeration / uses of magic
    numbers with the newly introduced PTP_MSGTYPE_* defines.

    On Friday, 20 November 2020, 23:39:10 CET, Vladimir Oltean wrote:
    > On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote:
    > > This series introduces commen defines for PTP event messages. Driver
    > > internal defines are removed and some uses of magic numbers are replaced
    > > by the new defines.
    > > [...]
    >
    > I understand that you don't want to spend a lifetime on this, but I see
    > that there are more drivers which you did not touch.
    >
    > is_sync() in drivers/net/phy/dp83640.c can be made to
    > return ptp_get_msgtype(hdr, type) == PTP_MSGTYPE_SYNC;
    >
    > this can be removed from drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h:
    > enum {
    > MLXSW_SP_PTP_MESSAGE_TYPE_SYNC,
    > MLXSW_SP_PTP_MESSAGE_TYPE_DELAY_REQ,
    > MLXSW_SP_PTP_MESSAGE_TYPE_PDELAY_REQ,
    > MLXSW_SP_PTP_MESSAGE_TYPE_PDELAY_RESP,
    > };
    I think that I have found an addtional one in the Microsemi VSC85xx PHY driver.



    \
     
     \ /
      Last update: 2020-11-22 09:30    [W:6.056 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site