lkml.org 
[lkml]   [2020]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 000/141] Fix fall-through warnings for Clang
    From
    Date
    On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
    > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
    > > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
    > > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
    > > > > Please tell me our reward for all this effort isn't a single
    > > > > missing error print.
    > > >
    > > > There were quite literally dozens of logical defects found
    > > > by the fallthrough additions. Very few were logging only.
    > >
    > > So can you give us the best examples (or indeed all of them if
    > > someone is keeping score)? hopefully this isn't a US election
    > > situation ...
    >
    > Gustavo? Are you running for congress now?
    >
    > https://lwn.net/Articles/794944/

    That's 21 reported fixes of which about 50% seem to produce no change
    in code behaviour at all, a quarter seem to have no user visible effect
    with the remaining quarter producing unexpected errors on obscure
    configuration parameters, which is why no-one really noticed them
    before.

    James


    \
     
     \ /
      Last update: 2020-11-22 20:55    [W:2.803 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site