lkml.org 
[lkml]   [2020]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 097/141] media: saa7134: Fix fall-through warnings for Clang
    Em Fri, 20 Nov 2020 12:37:08 -0600
    "Gustavo A. R. Silva" <gustavoars@kernel.org> escreveu:

    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a break statement instead of letting the code fall
    > through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

    Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    > ---
    > drivers/media/pci/saa7134/saa7134-tvaudio.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c
    > index 5cc4ef21f9d3..5dc97990fa0e 100644
    > --- a/drivers/media/pci/saa7134/saa7134-tvaudio.c
    > +++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c
    > @@ -885,6 +885,7 @@ void saa7134_enable_i2s(struct saa7134_dev *dev)
    > saa_writeb(SAA7134_I2S_OUTPUT_FORMAT, i2s_format);
    > saa_writeb(SAA7134_I2S_OUTPUT_LEVEL, 0x0F);
    > saa_writeb(SAA7134_I2S_AUDIO_OUTPUT, 0x01);
    > + break;
    >
    > default:
    > break;



    Thanks,
    Mauro

    \
     
     \ /
      Last update: 2020-11-22 17:34    [W:4.080 / U:0.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site