lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang
    From
    Date
    On 11/21/20 8:50 PM, Joe Perches wrote:
    >> What about moving the default to the end if the case, which is more common anyways:
    >>
    >> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > []
    >> @@ -295,16 +295,16 @@ static void peak_usb_write_bulk_callback(struct urb *urb)
    >>                 netif_trans_update(netdev);
    >>                 break;
    >>  
    >>
    >> - default:
    >> - if (net_ratelimit())
    >> - netdev_err(netdev, "Tx urb aborted (%d)\n",
    >> - urb->status);
    >>         case -EPROTO:
    >>         case -ENOENT:
    >>         case -ECONNRESET:
    >>         case -ESHUTDOWN:
    >> -
    >>                 break;
    >> +
    >> + default:
    >> + if (net_ratelimit())
    >> + netdev_err(netdev, "Tx urb aborted (%d)\n",
    >> + urb->status);
    >
    > That's fine and is more generally used style but this
    > default: case should IMO also end with a break;
    >
    > + break;

    I don't mind.

    process/coding-style.rst is not totally clear about the break after the default,
    if this is the lase one the switch statement.

    Marc

    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Embedded Linux | https://www.pengutronix.de |
    Vertretung West/Dortmund | Phone: +49-231-2826-924 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-11-22 00:06    [W:4.145 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site