Messages in this thread |  | | Date | Fri, 20 Nov 2020 15:41:07 +0100 | | From | Stefano Garzarella <> | | Subject | Re: [PATCH RFC 10/12] vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov |
| |
On Tue, Nov 17, 2020 at 11:27:03AM +0000, Stefan Hajnoczi wrote: >On Fri, Nov 13, 2020 at 02:47:10PM +0100, Stefano Garzarella wrote: >> vringh_getdesc_iotlb() manages 2 iovs for writable and readable >> descriptors. This is very useful for the block device, where for >> each request we have both types of descriptor. >> >> Let's split the vdpasim_virtqueue's iov field in riov and wiov >> to use them with vringh_getdesc_iotlb(). > >Is riov/wiov naming common? VIRTIO uses "in" (device-to-driver) and >"out" (driver-to-device). Using VIRTIO terminology might be clearer.
I followed the vringh_getdesc_iotlb() attribute names, but I agree that "in" and "out" would be better. I lost multiple times with read/write...
I'll fix!
Thanks, Stefano
|  |