lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 140/141] zd1201: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix a
    warning by replacing a /* Fall through */ comment with the new
    pseudo-keyword macro fallthrough; instead of letting the code fall
    through to the next case.

    Notice that Clang doesn't recognize /* Fall through */ comments as
    implicit fall-through markings.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/net/wireless/zydas/zd1201.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/zydas/zd1201.c b/drivers/net/wireless/zydas/zd1201.c
    index 718c4ee865ba..097805b55c59 100644
    --- a/drivers/net/wireless/zydas/zd1201.c
    +++ b/drivers/net/wireless/zydas/zd1201.c
    @@ -966,7 +966,7 @@ static int zd1201_set_mode(struct net_device *dev,
    */
    zd1201_join(zd, "\0-*#\0", 5);
    /* Put port in pIBSS */
    - /* Fall through */
    + fallthrough;
    case 8: /* No pseudo-IBSS in wireless extensions (yet) */
    porttype = ZD1201_PORTTYPE_PSEUDOIBSS;
    break;
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 20:10    [W:2.255 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site