lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 118/141] rtw88: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix a
    warning by replacing a /* fall through */ comment with the new
    pseudo-keyword macro fallthrough; instead of letting the code fall
    through to the next case.

    Notice that Clang doesn't recognize /* fall through */ comments as
    implicit fall-through markings.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/net/wireless/realtek/rtw88/fw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
    index 042015bc8055..e2d4bb180afd 100644
    --- a/drivers/net/wireless/realtek/rtw88/fw.c
    +++ b/drivers/net/wireless/realtek/rtw88/fw.c
    @@ -1473,7 +1473,7 @@ static bool rtw_fw_dump_check_size(struct rtw_dev *rtwdev,
    case RTW_FW_FIFO_SEL_RX:
    if ((start_addr + size) > rtwdev->chip->fw_fifo_addr[sel])
    return false;
    - /*fall through*/
    + fallthrough;
    default:
    return true;
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 20:10    [W:2.402 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site