lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 100/141] mtd: cfi: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements and a return
    instead of letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/mtd/chips/cfi_cmdset_0001.c | 1 +
    drivers/mtd/chips/cfi_cmdset_0002.c | 2 ++
    drivers/mtd/chips/cfi_cmdset_0020.c | 2 ++
    3 files changed, 5 insertions(+)

    diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
    index 42001c49833b..b7f5e7977dcd 100644
    --- a/drivers/mtd/chips/cfi_cmdset_0001.c
    +++ b/drivers/mtd/chips/cfi_cmdset_0001.c
    @@ -2549,6 +2549,7 @@ static int cfi_intelext_suspend(struct mtd_info *mtd)
    anyway? The latter for now. */
    printk(KERN_NOTICE "Flash device refused suspend due to active operation (state %d)\n", chip->state);
    ret = -EAGAIN;
    + break;
    case FL_PM_SUSPENDED:
    break;
    }
    diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
    index a1f3e1031c3d..6f6b0265c22d 100644
    --- a/drivers/mtd/chips/cfi_cmdset_0002.c
    +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
    @@ -902,6 +902,7 @@ static int get_chip(struct map_info *map, struct flchip *chip, unsigned long adr
    /* Someone else might have been playing with it. */
    goto retry;
    }
    + return 0;

    case FL_READY:
    case FL_CFI_QUERY:
    @@ -2994,6 +2995,7 @@ static int cfi_amdstd_suspend(struct mtd_info *mtd)
    * as the whole point is that nobody can do anything
    * with the chip now anyway.
    */
    + break;
    case FL_PM_SUSPENDED:
    break;

    diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
    index 270322bca221..d35df526e0a6 100644
    --- a/drivers/mtd/chips/cfi_cmdset_0020.c
    +++ b/drivers/mtd/chips/cfi_cmdset_0020.c
    @@ -1332,6 +1332,8 @@ static int cfi_staa_suspend(struct mtd_info *mtd)
    * as the whole point is that nobody can do anything
    * with the chip now anyway.
    */
    + break;
    +
    case FL_PM_SUSPENDED:
    break;

    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:3.315 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site