lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 009/141] igb: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements instead of just
    letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/net/ethernet/intel/igb/e1000_phy.c | 1 +
    drivers/net/ethernet/intel/igb/igb_ethtool.c | 1 +
    drivers/net/ethernet/intel/igb/igb_ptp.c | 1 +
    3 files changed, 3 insertions(+)

    diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
    index 8c8eb82e6272..a018000f7db9 100644
    --- a/drivers/net/ethernet/intel/igb/e1000_phy.c
    +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
    @@ -836,6 +836,7 @@ s32 igb_copper_link_setup_igp(struct e1000_hw *hw)
    break;
    case e1000_ms_auto:
    data &= ~CR_1000T_MS_ENABLE;
    + break;
    default:
    break;
    }
    diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
    index 28baf203459a..486d3e67d3a9 100644
    --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
    +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
    @@ -3022,6 +3022,7 @@ static int igb_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
    break;
    case ETHTOOL_SRXCLSRLDEL:
    ret = igb_del_ethtool_nfc_entry(adapter, cmd);
    + break;
    default:
    break;
    }
    diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c
    index 7cc5428c3b3d..f3ff565da0a1 100644
    --- a/drivers/net/ethernet/intel/igb/igb_ptp.c
    +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c
    @@ -1008,6 +1008,7 @@ static int igb_ptp_set_timestamp_mode(struct igb_adapter *adapter,
    switch (config->tx_type) {
    case HWTSTAMP_TX_OFF:
    tsync_tx_ctl = 0;
    + break;
    case HWTSTAMP_TX_ON:
    break;
    default:
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:2.984 / U:1.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site