lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 054/141] target: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
    of warnings by explicitly adding a break statement and a fallthrough
    pseudo-keyword instead of letting the code fall through to the next
    case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/target/target_core_iblock.c | 1 +
    drivers/target/target_core_pr.c | 1 +
    2 files changed, 2 insertions(+)

    diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
    index f2bd2e207e0b..8ed93fd205c7 100644
    --- a/drivers/target/target_core_iblock.c
    +++ b/drivers/target/target_core_iblock.c
    @@ -211,6 +211,7 @@ static unsigned long long iblock_emulate_read_cap_with_block_size(
    break;
    case 512:
    blocks_long <<= 3;
    + break;
    default:
    break;
    }
    diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
    index 5f79ea05f9b8..14db5e568f22 100644
    --- a/drivers/target/target_core_pr.c
    +++ b/drivers/target/target_core_pr.c
    @@ -337,6 +337,7 @@ static int core_scsi3_pr_seq_non_holder(struct se_cmd *cmd, u32 pr_reg_type,
    switch (pr_reg_type) {
    case PR_TYPE_WRITE_EXCLUSIVE:
    we = 1;
    + fallthrough;
    case PR_TYPE_EXCLUSIVE_ACCESS:
    /*
    * Some commands are only allowed for the persistent reservation
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:34    [W:4.111 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site