lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 020/141] scsi: aic7xxx: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements instead of just
    letting the code fall through to the next case, and by adding fallthrough
    statements in places where the code is intended to fall through, and
    finally by replacing /* FALLTHROUGH */ comments with the new
    pseudo-keyword macro fallthrough.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/scsi/aic7xxx/aic79xx_core.c | 4 +++-
    drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++--
    2 files changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
    index 98b02e7d38bb..dd8d6646b06f 100644
    --- a/drivers/scsi/aic7xxx/aic79xx_core.c
    +++ b/drivers/scsi/aic7xxx/aic79xx_core.c
    @@ -6130,6 +6130,7 @@ ahd_free(struct ahd_softc *ahd)
    fallthrough;
    case 2:
    ahd_dma_tag_destroy(ahd, ahd->shared_data_dmat);
    + break;
    case 1:
    break;
    case 0:
    @@ -6542,8 +6543,8 @@ ahd_fini_scbdata(struct ahd_softc *ahd)
    kfree(hscb_map);
    }
    ahd_dma_tag_destroy(ahd, scb_data->hscb_dmat);
    - /* FALLTHROUGH */
    }
    + fallthrough;
    case 4:
    case 3:
    case 2:
    @@ -8911,6 +8912,7 @@ ahd_handle_scsi_status(struct ahd_softc *ahd, struct scb *scb)
    break;
    case SIU_PFC_ILLEGAL_REQUEST:
    printk("Illegal request\n");
    + break;
    default:
    break;
    }
    diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
    index 725bb7f58054..2df664e3e954 100644
    --- a/drivers/scsi/aic7xxx/aic7xxx_core.c
    +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
    @@ -4478,6 +4478,7 @@ ahc_free(struct ahc_softc *ahc)
    fallthrough;
    case 2:
    ahc_dma_tag_destroy(ahc, ahc->shared_data_dmat);
    + fallthrough;
    case 1:
    break;
    case 0:
    @@ -5867,9 +5868,8 @@ ahc_search_qinfifo(struct ahc_softc *ahc, int target, char channel,
    if ((scb->flags & SCB_ACTIVE) == 0)
    printk("Inactive SCB in qinfifo\n");
    ahc_done(ahc, scb);
    -
    - /* FALLTHROUGH */
    }
    + fallthrough;
    case SEARCH_REMOVE:
    break;
    case SEARCH_COUNT:
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:29    [W:4.101 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site