Messages in this thread | | | Date | Mon, 2 Nov 2020 08:09:50 -0800 | From | Jaegeuk Kim <> | Subject | Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value |
| |
On 10/28, Chao Yu wrote: > On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote: > > 'ret' should not have been used here: otherwise, it would be wrongly used > > as the error code and then be returned from main(). > > > > Signed-off-by: Robin Hsu <robinhsu@google.com> > > BTW, how about changing 'ret = EXIT_ERR_CODE' to > 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though. > > Reviewed-by: Chao Yu <yuchao0@huawei.com>
I think it'd be good to go as is for now. :)
> > Thanks,
| |