Messages in this thread Patch in this message | | | Date | Mon, 2 Nov 2020 13:41:25 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH 17/23] mtd: nand: raw: s3c2410: Add documentation for 2 missing struct members |
| |
On Mon, Nov 02, 2020 at 11:54:00AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/mtd/nand/raw/s3c2410.c:172: warning: Function parameter or member 'controller' not described in 's3c2410_nand_info' > drivers/mtd/nand/raw/s3c2410.c:172: warning: Function parameter or member 'freq_transition' not described in 's3c2410_nand_info'
It took me some time to spot why the "mtds" change is there, so maybe add to the commit msg: "Correct also typo controoler -> controller."
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Ben Dooks <ben@simtec.co.uk> > Cc: linux-mtd@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mtd/nand/raw/s3c2410.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/s3c2410.c b/drivers/mtd/nand/raw/s3c2410.c > index cb2d1b4e278cb..f0a4535c812aa 100644 > --- a/drivers/mtd/nand/raw/s3c2410.c > +++ b/drivers/mtd/nand/raw/s3c2410.c > @@ -133,7 +133,8 @@ enum s3c_nand_clk_state { > > /** > * struct s3c2410_nand_info - NAND controller state. > - * @mtds: An array of MTD instances on this controoler. > + * @controller: Base controller structure. > + * @mtds: An array of MTD instances on this controller.
| |