Messages in this thread | | | Date | Mon, 2 Nov 2020 08:39:55 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 3/9] mfd: intel_soc_pmic: remove unnecessary CONFIG_PM_SLEEP |
| |
On Thu, 29 Oct 2020, Andy Shevchenko wrote:
> On Thu, Oct 29, 2020 at 5:27 PM Lee Jones <lee.jones@linaro.org> wrote: > > On Thu, 29 Oct 2020, Coiby Xu wrote: > > > On Thu, Oct 29, 2020 at 01:00:29PM +0200, Andy Shevchenko wrote: > > > > On Thu, Oct 29, 2020 at 06:06:41PM +0800, Coiby Xu wrote: > > > > > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > > > > > > > Have you compiled this with > > > > % make W=1 ... > > > > ? > > > > > > > > > > Sorry my bad. I thought I had run "make modules" with CONFIG_PM_SLEEP > > > disabled. I'll run "make W=1 M=..." for each driver after adding > > > __maybe_unused in v2. > > > > No, thank you. Just keep it as it is. > > > > The current code is space saving. > > Perhaps you need to go thru __maybe_unused handling. > There are pros and cons of each approach, but not above.
Do you know that all compilers drop the section?
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |