Messages in this thread | | | From | Rob Herring <> | Date | Thu, 19 Nov 2020 08:17:26 -0600 | Subject | Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout |
| |
On Thu, Nov 19, 2020 at 5:12 AM Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Tue, Sep 22, 2020 at 11:30:30AM -0600, Rob Herring wrote: > > On Mon, Sep 21, 2020 at 1:50 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > > > > > When establish link timeouts, probe fails but the error is unrelated since > > > the PCIe controller has been probed succesfully. > > > > > > Align with most of the other dw-pcie drivers and ignore return of > > > dw_pcie_wait_for_link() in the host_init callback. > > > > I think all, not most DWC drivers should be aligned. Plus the code > > here is pretty much the same, so I'm working on moving all this to the > > common DWC code. Drivers that need to bring up the link will need to > > implement .start_link() (currently only used for EP mode). Most of the > > time that is just setting the LTSSM bit which Synopsys thought letting > > every vendor do their own register for was a good idea. Sigh. > > Should I drop this patch then ?
Yes, this is done by my series.
Rob
| |