lkml.org 
[lkml]   [2020]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg
Applied.  Thanks!

Alex

On Wed, Nov 18, 2020 at 3:17 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 18.11.20 um 03:42 schrieb Bernard Zhao:
> > Fix check_patch.pl warning:
> > kmalloc_array uses number as first arg, sizeof is generally wrong.
> > +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids,
> > GFP_KERNEL);
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > index 6e9a9e5dbea0..f2bd4b0e06f6 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > @@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
> > if (ring->vmid_wait && !dma_fence_is_signaled(ring->vmid_wait))
> > return amdgpu_sync_fence(sync, ring->vmid_wait);
> >
> > - fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);
> > + fences = kmalloc_array(id_mgr->num_ids, sizeof(void *), GFP_KERNEL);
> > if (!fences)
> > return -ENOMEM;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

\
 
 \ /
  Last update: 2020-11-19 22:56    [W:0.767 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site