Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning | Date | Thu, 19 Nov 2020 22:07:01 +0100 |
| |
On Thu, 2020-11-12 at 18:00:37 UTC, Serge Semin wrote: > sparse is unhappy with us casting the __iomem address space pointer to > a type with no address space attribute specified: > > "sparse warnings: (new ones prefixed by >>)" > >> drivers/mtd/maps/physmap-bt1-rom.c:78:18: sparse: sparse: cast removes address space '__iomem' of expression > > Indeed we perform the __iomem-less type casting but to an integer > variable. The integer variable isn't dereferenced then, so the casting is > safe and won't cause any problem. But in order to make sparse happy let's > fix the warning just by converting the local "shift" and "chunk" variables > to the "unsigned int" type. Add the same fix to the bt1_rom_map_read() > method for unification. > > Fixes: b3e79e7682e0 ("mtd: physmap: Add Baikal-T1 physically mapped ROM support") > Link: https://lore.kernel.org/lkml/202011021254.XC70BaQT-lkp@intel.com/ > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
| |