lkml.org 
[lkml]   [2020]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 3/4] media: i2c: imx258: simplify getting state container
    Date
    The pointer to 'struct v4l2_subdev' is stored in drvdata via
    v4l2_i2c_subdev_init() so there is no point of a dance like:

    struct i2c_client *client = to_i2c_client(struct device *dev)
    struct v4l2_subdev *sd = i2c_get_clientdata(client);

    This allows to remove local variable 'client' and few pointer
    dereferences.

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

    ---

    Changes since v3:
    1. None

    Changes since v2:
    1. New patch
    ---
    drivers/media/i2c/imx258.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
    index ba7f29622974..505981e02cff 100644
    --- a/drivers/media/i2c/imx258.c
    +++ b/drivers/media/i2c/imx258.c
    @@ -1018,8 +1018,7 @@ static int imx258_set_stream(struct v4l2_subdev *sd, int enable)

    static int __maybe_unused imx258_suspend(struct device *dev)
    {
    - struct i2c_client *client = to_i2c_client(dev);
    - struct v4l2_subdev *sd = i2c_get_clientdata(client);
    + struct v4l2_subdev *sd = dev_get_drvdata(dev);
    struct imx258 *imx258 = to_imx258(sd);

    if (imx258->streaming)
    @@ -1030,8 +1029,7 @@ static int __maybe_unused imx258_suspend(struct device *dev)

    static int __maybe_unused imx258_resume(struct device *dev)
    {
    - struct i2c_client *client = to_i2c_client(dev);
    - struct v4l2_subdev *sd = i2c_get_clientdata(client);
    + struct v4l2_subdev *sd = dev_get_drvdata(dev);
    struct imx258 *imx258 = to_imx258(sd);
    int ret;

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-18 21:29    [W:5.072 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site