lkml.org 
[lkml]   [2020]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: md: dm-writeback: add __noreturn to BUG-ging function
    From
    Date
    On 11/18/20 8:35 AM, Christian Borntraeger wrote:
    >
    >
    > On 18.11.20 17:07, Mike Snitzer wrote:
    >> On Wed, Nov 18 2020 at 10:49am -0500,
    >> Mike Snitzer <snitzer@redhat.com> wrote:
    >>
    >>> I don't think my suggestion will help.. given it'd still leave
    >>> persistent_memory_claim() without a return statement.
    >>>
    >>> Think it worthwhile to just add a dummy 'return 0;' after the BUG().
    >>
    >> Decided to go with this, now staged for 5.11:
    >> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=a1e4865b4dda7071f3707f7e551289ead66e38b1
    >>
    >
    > Looks like a sane solution. Thank you for following up.

    Yes, thanks again.

    --
    ~Randy

    \
     
     \ /
      Last update: 2020-11-18 17:42    [W:3.712 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site