Messages in this thread | | | Date | Wed, 18 Nov 2020 21:20:38 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v5] dmaengine: qcom: Add ADM driver |
| |
On 14-11-20, 14:02, Jonathan McDowell wrote: > Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA > controller found in the MSM8x60 and IPQ/APQ8064 platforms. > > The ADM supports both memory to memory transactions and memory > to/from peripheral device transactions. The controller also provides > flow control capabilities for transactions to/from peripheral devices. > > The initial release of this driver supports slave transfers to/from > peripherals and also incorporates CRCI (client rate control interface) > flow control. > > The hardware only supports a 32 bit physical address, so specifying > !PHYS_ADDR_T_64BIT gives maximum COMPILE_TEST coverage without having to > spend effort on kludging things in the code that will never actually be > needed on real hardware.
Applied, thanks
My build scripts emit the warnings below, please fix them up with the follow up patch. You can get this with W=1
drivers/dma/qcom/qcom_adm.c:180: warning: Function parameter or member 'chan' not described in 'adm_free_chan' drivers/dma/qcom/qcom_adm.c:190: warning: Function parameter or member 'burst' not described in 'adm_get_blksize' drivers/dma/qcom/qcom_adm.c:466: warning: Function parameter or member 'chan' not described in 'adm_terminate_all' drivers/dma/qcom/qcom_adm.c:466: warning: Excess function parameter 'achan' description in 'adm_terminate_all' drivers/dma/qcom/qcom_adm.c:503: warning: Function parameter or member 'achan' not described in 'adm_start_dma'
-- ~Vinod
| |