Messages in this thread | | | Date | Wed, 18 Nov 2020 14:57:02 +0100 | From | Martin Schiller <> | Subject | Re: [PATCH net-next v2 5/6] net/lapb: support netdev events |
| |
On 2020-11-18 14:46, Xie He wrote: > On Wed, Nov 18, 2020 at 5:03 AM Xie He <xie.he.0141@gmail.com> wrote: >> >> On Wed, Nov 18, 2020 at 12:49 AM Martin Schiller <ms@dev.tdt.de> >> wrote: >> > >> > I also have a patch here that implements an "on demand" link feature, >> > which we used for ISDN dialing connections. >> > As ISDN is de facto dead, this is not relevant anymore. But if we want >> > such kind of feature, I think we need to stay with the method to control >> > L2 link state from L3. >> >> I see. Hmm... >> >> I guess for ISDN, the current code (before this patch series) is the >> best. We only establish the connection when L3 has packets to send. >> >> Can we do this? We let L2 handle all device-up / device-down / >> carrier-up / carrier-down events. And when L3 has some packets to send >> but it still finds the L2 link is not up, it will then instruct L2 to >> connect. >> >> This way we may be able to both keep the logic simple and still keep >> L3 compatible with ISDN. > > Another solution might be letting ISDN automatically connect when it > receives the first packet from L3. This way we can still free L3 from > all handlings of L2 connections.
ISDN is not important now. Also the I4L subsystem has been removed.
I have now completely reworked the patch-set and it is now much tidier. For now I left the event handling completely in X.25 (L3).
I will now send the whole thing as v3 and we can discuss it further.
| |