lkml.org 
[lkml]   [2020]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] USB: serial: mos7720: defer state restore to a workqueue
On Tue, Nov 17, 2020 at 08:48:37AM -0800, Davidlohr Bueso wrote:
> The parallel port restore operation currently defers writes
> to a tasklet, if it sees a locked disconnect mutex. The
> driver goes to a lot of trouble to ensure writes happen
> in a non-blocking context, but things can be greatly
> simplified if it's done in regular process context and
> this is not a system performance critical path. As such,
> instead of doing the state restore writes in irq context,
> use a workqueue and just do regular synchronous writes.
>
> In addition to the cleanup, this also imposes less on the
> overall system as tasklets have been deprecated because
> of it's BH implications, potentially blocking a higher
> priority task from running. We also get rid of hacks
> such as trylocking a mutex in irq, something which does

So this was never done in irq either. Perhaps you can remove that bit
too.

> not play nice with priority boosting in PREEMPT_RT.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> Changes from v1: remove bogus irq comment.

You seem to have some problem with your mail setup. The patch fails to
apply, and both checkpatch and git warn about the patch being corrupt:

warning: Patch sent with format=flowed; space at the end of lines might be lost.
Applying: USB: serial: mos7720: defer state restore to a workqueue
error: corrupt patch at line 12
Patch failed at 0001 USB: serial: mos7720: defer state restore to a workqueue

Can you look into that and verify that you can send the patch to
yourself and apply it first?

Johan

\
 
 \ /
  Last update: 2020-11-18 11:12    [W:0.083 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site