lkml.org 
[lkml]   [2020]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] docs/vm: remove unused 3 items explanation for /proc/vmstat
From
Date


在 2020/11/19 上午4:46, Jonathan Corbet 写道:
> On Mon, 16 Nov 2020 17:51:22 +0800
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
>
>> Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success
>> stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs
>> still has their explanation. let's remove them.
>>
>> "compact_blocks_moved",
>> "compact_pages_moved",
>> "compact_pagemigrate_failed",
>
> So a quick look says that the above-mentioned patch didn't remove those
> three items; two of them were, instead, renamed. Rather than just taking
> out the old information, it seems we should actually update it to reflect
> current reality?
>

I thought about the replacement, but there are couple of migration events
have no explanation:

#ifdef CONFIG_MIGRATION
"pgmigrate_success",
"pgmigrate_fail",
"thp_migration_success",
"thp_migration_fail",
"thp_migration_split",
#endif

It's better to fill them together, also change current explanation accordinglly.
but I'm not so confident on this now...

Thanks
Alex

\
 
 \ /
  Last update: 2020-11-19 03:15    [W:0.045 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site