lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 103/151] cosa: Add missing kfree in error path of cosa_write
    Date
    From: Wang Hai <wanghai38@huawei.com>

    [ Upstream commit 52755b66ddcef2e897778fac5656df18817b59ab ]

    If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a
    corresponding kfree() in exception handling. Thus add kfree() for this
    function implementation.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wang Hai <wanghai38@huawei.com>
    Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
    Link: https://lore.kernel.org/r/20201110144614.43194-1-wanghai38@huawei.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wan/cosa.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
    index af539151d6638..61428076f32e4 100644
    --- a/drivers/net/wan/cosa.c
    +++ b/drivers/net/wan/cosa.c
    @@ -889,6 +889,7 @@ static ssize_t cosa_write(struct file *file,
    chan->tx_status = 1;
    spin_unlock_irqrestore(&cosa->lock, flags);
    up(&chan->wsem);
    + kfree(kbuf);
    return -ERESTARTSYS;
    }
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-17 14:39    [W:4.113 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site