lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI
On Tue, Nov 17, 2020 at 12:42 PM Jonathan Cameron
<Jonathan.Cameron@huawei.com> wrote:
>
> On Tue, 17 Nov 2020 09:52:52 +0200
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
> > This change converts the configuration of the dual-channel mode from the
> > old platform-data, to the device_property_present() function, which
> > supports both device-tree and ACPI configuration setups.
> >
> > With this change the old platform_data include of the driver can be
> > removed.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Hi Alex,
>
> I'm a bit in too minds about device_property_present()
> vs device_property_read_bool() which are the same thing under the hood.
>
> Not sure which one conveys the correct semantics here.
> I don't feel strongly enough about it though to do more than raise
> eyebrows (i.e. not blocking this series).

The idea as I understand it is that the 'present' can be run against
any type of property, while 'bool' is specifically for boolean (the
similarities is a detail of implementation).

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-11-17 12:10    [W:0.132 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site