Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 18 Nov 2020 01:15:31 +0100 | Subject | Re: [LINUX PATCH V3 5/9] gpio: gpio-xilinx: Add interrupt support |
| |
Hi Srinivas!
On Thu, Nov 12, 2020 at 6:12 PM Srinivas Neeli <srinivas.neeli@xilinx.com> wrote:
> Adds interrupt support to the Xilinx GPIO driver so that rising and > falling edge line events can be supported. Since interrupt support is > an optional feature in the Xilinx IP, the driver continues to support > devices which have no interrupt provided. > > Signed-off-by: Robert Hancock <hancock@sedsystems.ca> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
(...) > config GPIO_XILINX > tristate "Xilinx GPIO support" > + select GPIOLIB_IRQCHIP > + depends on OF_GPIO > help > Say yes here to support the Xilinx FPGA GPIO device
Please add: select IRQ_DOMAIN_HIERARCHY
Because your driver requires this.
> + /* Update cells with gpio-cells value */ > + if (of_property_read_u32(np, "#gpio-cells", &cells)) > + dev_dbg(&pdev->dev, "Missing gpio-cells property\n"); (...) > + chip->gc.of_gpio_n_cells = cells;
Why is this necessary? Mention in the commit.
Other than that this looks very good and good use of the hierarchical IRQ feature in gpiolib!
Yours, Linus Walleij
| |