lkml.org 
[lkml]   [2020]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 127/151] selinux: Fix error return code in sel_ib_pkey_sid_slow()
    Date
    From: Chen Zhou <chenzhou10@huawei.com>

    commit c350f8bea271782e2733419bd2ab9bf4ec2051ef upstream.

    Fix to return a negative error code from the error handling case
    instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere
    in this function.

    Cc: stable@vger.kernel.org
    Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of PKey SIDs")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
    Signed-off-by: Paul Moore <paul@paul-moore.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    security/selinux/ibpkey.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/security/selinux/ibpkey.c
    +++ b/security/selinux/ibpkey.c
    @@ -151,8 +151,10 @@ static int sel_ib_pkey_sid_slow(u64 subn
    * is valid, it just won't be added to the cache.
    */
    new = kzalloc(sizeof(*new), GFP_ATOMIC);
    - if (!new)
    + if (!new) {
    + ret = -ENOMEM;
    goto out;
    + }

    new->psec.subnet_prefix = subnet_prefix;
    new->psec.pkey = pkey_num;

    \
     
     \ /
      Last update: 2020-11-17 15:10    [W:3.595 / U:1.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site