lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] checkpatch: avoid COMMIT_LOG_LONG_LINE warning for signature tags
From
Date
On Mon, 2020-11-16 at 14:07 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns us for long lines in commits even for
> signature tag lines.

Thanks Aditya.

Acked-by: Joe Perches <joe@perches.com>

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2961,8 +2961,8 @@ sub process {
>   # file delta changes
>   $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
>   # filename then :
> - $line =~ /^\s*(?:Fixes:|Link:)/i ||
> - # A Fixes: or Link: line
> + $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
> + # A Fixes: or Link: line or signature tag line
>   $commit_log_possible_stack_dump)) {
>   WARN("COMMIT_LOG_LONG_LINE",
>   "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);


\
 
 \ /
  Last update: 2020-11-16 18:01    [W:0.102 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site