lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v12 0/5] userspace MHI client interface driver
    Date
    This patch series adds support for UCI driver. UCI driver enables userspace
    clients to communicate to external MHI devices like modem and WLAN. UCI driver
    probe creates standard character device file nodes for userspace clients to
    perform open, read, write, poll and release file operations. These file
    operations call MHI core layer APIs to perform data transfer using MHI bus
    to communicate with MHI device. It also adds a loopback test application to
    verify the UCI LOOPBACK channel. Patch is tested using arm64 based platform.

    V12:
    - Added loopback test driver under selftest/drivers/mhi. Updated kernel
    documentation for the usage of the loopback test application.
    - Addressed review comments for renaming variable names, updated inline
    comments and removed two redundant dev_dbg.

    V11:
    - Fixed review comments for UCI documentation by expanding TLAs and rewording
    some sentences.

    V10:
    - Replaced mutex_lock with mutex_lock_interruptible in read() and write() file
    ops call back.

    V9:
    - Renamed dl_lock to dl_pending _lock and pending list to dl_pending for
    clarity.
    - Used read lock to protect cur_buf.
    - Change transfer status check logic and only consider 0 and -EOVERFLOW as
    only success.
    - Added __int to module init function.
    - Print channel name instead of minor number upon successful probe.

    V8:
    - Fixed kernel test robot compilation error by changing %lu to %zu for
    size_t.
    - Replaced uci with UCI in Kconfig, commit text, and comments in driver
    code.
    - Fixed minor style related comments.

    V7:
    - Decoupled uci device and uci channel objects. uci device is
    associated with device file node. uci channel is associated
    with MHI channels. uci device refers to uci channel to perform
    MHI channel operations for device file operations like read()
    and write(). uci device increments its reference count for
    every open(). uci device calls mhi_uci_dev_start_chan() to start
    the MHI channel. uci channel object is tracking number of times
    MHI channel is referred. This allows to keep the MHI channel in
    start state until last release() is called. After that uci channel
    reference count goes to 0 and uci channel clean up is performed
    which stops the MHI channel. After the last call to release() if
    driver is removed uci reference count becomes 0 and uci object is
    cleaned up.
    - Use separate uci channel read and write lock to fine grain locking
    between reader and writer.
    - Use uci device lock to synchronize open, release and driver remove.
    - Optimize for downlink only or uplink only UCI device.

    V6:
    - Moved uci.c to mhi directory.
    - Updated Kconfig to add module information.
    - Updated Makefile to rename uci object file name as mhi_uci
    - Removed kref for open count

    V5:
    - Removed mhi_uci_drv structure.
    - Used idr instead of creating global list of uci devices.
    - Used kref instead of local ref counting for uci device and
    open count.
    - Removed unlikely macro.

    V4:
    - Fix locking to protect proper struct members.
    - Updated documentation describing uci client driver use cases.
    - Fixed uci ref counting in mhi_uci_open for error case.
    - Addressed style related review comments.

    V3: Added documentation for MHI UCI driver.

    V2:
    - Added mutex lock to prevent multiple readers to access same
    - mhi buffer which can result into use after free.

    Hemant Kumar (5):
    bus: mhi: core: Add helper API to return number of free TREs
    bus: mhi: core: Move MHI_MAX_MTU to external header file
    docs: Add documentation for userspace client interface
    bus: mhi: Add userspace client interface driver
    selftest: mhi: Add support to test MHI LOOPBACK channel

    Documentation/mhi/index.rst | 1 +
    Documentation/mhi/uci.rst | 109 +++
    drivers/bus/mhi/Kconfig | 13 +
    drivers/bus/mhi/Makefile | 3 +
    drivers/bus/mhi/core/internal.h | 1 -
    drivers/bus/mhi/core/main.c | 12 +
    drivers/bus/mhi/uci.c | 667 +++++++++++++++++
    include/linux/mhi.h | 12 +
    tools/testing/selftests/Makefile | 1 +
    tools/testing/selftests/drivers/.gitignore | 1 +
    tools/testing/selftests/drivers/mhi/Makefile | 8 +
    tools/testing/selftests/drivers/mhi/config | 2 +
    .../testing/selftests/drivers/mhi/loopback_test.c | 789 +++++++++++++++++++++
    13 files changed, 1618 insertions(+), 1 deletion(-)
    create mode 100644 Documentation/mhi/uci.rst
    create mode 100644 drivers/bus/mhi/uci.c
    create mode 100644 tools/testing/selftests/drivers/mhi/Makefile
    create mode 100644 tools/testing/selftests/drivers/mhi/config
    create mode 100644 tools/testing/selftests/drivers/mhi/loopback_test.c

    --
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2020-11-16 23:50    [W:5.607 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site