[lkml]   [2020]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 04/16] mm: Add FGP_ENTRY
On Thu, Nov 12, 2020 at 09:26:29PM +0000, Matthew Wilcox (Oracle) wrote:
> The functionality of find_lock_entry() and find_get_entry() can be
> provided by pagecache_get_pages(),


> which lets us delete find_lock_entry()
> and make find_get_entry() static.

I think this should mention that find_get_entry is now only used by
pagecache_get_page. That answers the obvious questions of why we could
not switch all callers of find_get_entry to pagecache_get_page.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <>

 \ /
  Last update: 2020-11-14 11:03    [W:0.204 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site