Messages in this thread | | | Date | Thu, 12 Nov 2020 17:41:50 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH v3 01/12] mm: Make pagecache tagged lookups return only head pages |
| |
On Wed, Oct 28, 2020 at 09:50:56AM +0200, Mike Rapoport wrote: > > @@ -2074,8 +2074,8 @@ EXPORT_SYMBOL(find_get_pages_contig); > > * @nr_pages: the maximum number of pages > > * @pages: where the resulting pages are placed > > * > > - * Like find_get_pages, except we only return pages which are tagged with > > - * @tag. We update @index to index the next page for the traversal. > > + * Like find_get_pages(), except we only return head pages which are tagged > > + * with @tag. We update @index to index the next page for the traversal. > > Nit: ^ next head page
I don't love the sentence anyway. How about:
* Like find_get_pages(), except we only return head pages which are tagged * with @tag. @index is updated to the index immediately after the last * page we return, ready for the next iteration.
| |