lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/12] mm: Make pagecache tagged lookups return only head pages
On Wed, Oct 28, 2020 at 09:50:56AM +0200, Mike Rapoport wrote:
> > @@ -2074,8 +2074,8 @@ EXPORT_SYMBOL(find_get_pages_contig);
> > * @nr_pages: the maximum number of pages
> > * @pages: where the resulting pages are placed
> > *
> > - * Like find_get_pages, except we only return pages which are tagged with
> > - * @tag. We update @index to index the next page for the traversal.
> > + * Like find_get_pages(), except we only return head pages which are tagged
> > + * with @tag. We update @index to index the next page for the traversal.
>
> Nit: ^ next head page

I don't love the sentence anyway. How about:

* Like find_get_pages(), except we only return head pages which are tagged
* with @tag. @index is updated to the index immediately after the last
* page we return, ready for the next iteration.

\
 
 \ /
  Last update: 2020-11-12 18:43    [W:0.059 / U:2.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site