lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 28/44] arm64: mte: Reset the page tag in page->flags
From
Date
On 11/12/20 9:31 AM, Catalin Marinas wrote:
> On Tue, Nov 10, 2020 at 11:10:25PM +0100, Andrey Konovalov wrote:
>> diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c
>> index 70a71f38b6a9..f0efa4847e2f 100644
>> --- a/arch/arm64/mm/copypage.c
>> +++ b/arch/arm64/mm/copypage.c
>> @@ -23,6 +23,7 @@ void copy_highpage(struct page *to, struct page *from)
>>
>> if (system_supports_mte() && test_bit(PG_mte_tagged, &from->flags)) {
>> set_bit(PG_mte_tagged, &to->flags);
>> + page_kasan_tag_reset(to);
>> mte_copy_page_tags(kto, kfrom);
>
> Any reason why this doesn't have an smp_wmb() between resetting the tags
> and copying them into kto?
>

Yes, the reason is I am not sure why it disappeared from the submitted patch ;)
I am going to respin the patch.

--
Regards,
Vincenzo

\
 
 \ /
  Last update: 2020-11-12 10:37    [W:0.075 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site