lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO
On Thu, 12 Nov 2020 17:43:56 -0800 Dave Hansen wrote:
> On 11/12/20 4:24 PM, Jakub Kicinski wrote:
> > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote:
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot <lkp@intel.com>
> > Good people of kernel test robot, could you please rephrase this to say
> > that the tag is only appropriate if someone is sending a fix up/follow
> > up patch?
> >
> > Folks keep adding those tags on the next revisions of the their patches
> > which is quite misleading.
>
> I think it's still fair for the lkp folks to get *some* credit for
> reporting these bugs.  I mean, the stated reason[1] for it existing is:
>
> The Reported-by tag gives credit to people who find bugs and
> report them and it hopefully inspires them to help us again in
> the future.
>
> I do agree, though, that it's confusing *what* they reported, especially
> if the patch in question is fixing something *else*. Rather than invent
> a new tag, maybe a comment would suffice:
>
> Reported-by: kernel test robot <lkp@intel.com> # bug in earlier revision

Fine by me, although its not common to add Reported-by tags for people
who point out issues in review, so why add a tag for the bot?

\
 
 \ /
  Last update: 2020-11-13 02:54    [W:0.086 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site