Messages in this thread | | | Subject | Re: [PATCH] scsi: ufs: show lba and length for unmap commands | From | Stanley Chu <> | Date | Fri, 13 Nov 2020 09:10:39 +0800 |
| |
Hi,
On Thu, 2020-11-12 at 08:59 -0800, Jaegeuk Kim wrote: > From: Leo Liou <leoliou@google.com> > > We have lba and length for unmap commands. > > Signed-off-by: Leo Liou <leoliou@google.com> > --- > drivers/scsi/ufs/ufshcd.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 86c8dee01ca9..dba3ee307307 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -376,6 +376,11 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, > lrbp->ucd_req_ptr->sc.exp_data_transfer_len); > if (opcode == WRITE_10) > group_id = lrbp->cmd->cmnd[6]; > + } else if (opcode == UNMAP) { > + if (cmd->request) { > + lba = scsi_get_lba(cmd); > + transfer_len = blk_rq_bytes(cmd->request); > + }
Nitpicking: Perhaps we could unify the method of obtaining both lba and transfer_len for all READ/WRITE/UNMAP commands?
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
> } > } >
| |